Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beta::Button CSS bug fixes #1427

Merged
merged 4 commits into from
Sep 30, 2022
Merged

Beta::Button CSS bug fixes #1427

merged 4 commits into from
Sep 30, 2022

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Sep 29, 2022 •
edited
Loading

Tiny fixes

  • Ensure hover/active states aren't visible when a button is disabled
  • Remove unused classes
  • Ensure buttons will maintain their max-width even in squishy flex layout situations

@langermank langermank requested a review from a team as a code owner September 29, 2022 23:28
@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: eb01cf0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/view-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@langermank langermank requested a review from a team September 29, 2022 23:29
@langermank langermank temporarily deployed to review-pr-1427 September 29, 2022 23:29 Inactive
@langermank langermank enabled auto-merge (squash) September 29, 2022 23:29
@langermank langermank temporarily deployed to github-pages September 29, 2022 23:33 Inactive
@langermank langermank temporarily deployed to github-pages September 30, 2022 00:09 Inactive
@langermank langermank merged commit 2139fa3 into main Sep 30, 2022
@langermank langermank deleted the button-nitpicks branch September 30, 2022 14:20
@primer-css primer-css mentioned this pull request Sep 30, 2022
Merged
jonrohan pushed a commit that referenced this pull request Sep 30, 2022
@langermank @jonrohan
Beta::Button CSS bug fixes (#1427)
2fe773b 
* fine tune button fixes

* Create tough-bags-double.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithamus keithamus keithamus approved these changes

@jonrohan jonrohan Awaiting requested review from jonrohan jonrohan is a code owner automatically assigned from primer/css-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@langermank @keithamus